Use quadrature to compute environmental ql, qi instead of mean #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costachris
force-pushed
the
env_ql_quad
branch
from
3f9cb05 to
c1c9726
Compare
costachris
changed the title
costachris
force-pushed
the
env_ql_quad
branch
2 times, most recently
from
a66c5a1 to
7852ecb
Compare
trontrytel
reviewed
Mar 4, 2024
trontrytel
reviewed
Mar 4, 2024
trontrytel
reviewed
Mar 4, 2024
trontrytel
approved these changes
Mar 4, 2024
costachris
force-pushed
the
env_ql_quad
branch
2 times, most recently
from
e625ddc to
342991a
Compare
costachris
force-pushed
the
env_ql_quad
branch
8 times, most recently
from
5e94179 to
34be186
Compare
…y microphysics to handle sat/unsat cases with placeholder values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use quadratures to compute environmental ql, qi . Previously this was causing instances of nonzero env cloud fraction with zero ql.
Remove shrink_mask and use placeholder values for environment sat when no env cloud fraction. This is to address spurious large gradients when there's noisy switching between cloudy/noncloudy env air.