(0.1.9) Ensure consistency in the last row. (#58)

* fix last row

* update

* add a test

* Update zipper_boundary_condition.jl

* Update test_zipper_boundary_conditions.jl

* fix test

* correct tests

Project.toml

@@ -1,7 +1,7 @@
 name = "OrthogonalSphericalShellGrids"
 uuid = "c2be9673-fb75-4747-82dc-aa2bb9f4aed0"
 authors = ["Climate Modeling Alliance and contributors"]
-version = "0.1.8"
+version = "0.1.9"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

src/zipper_boundary_condition.jl

@@ -46,6 +46,7 @@ c₂ == c₃
 ```
 
 This is not the case for the v-velocity (or any field on the j-faces) where the last grid point is not repeated.
+Because of this redundancy, we ensure consistency by substituting the redundant part of fields Centered in x, in the last row.
 """
 ZipperBoundaryCondition(sign = 1) = BoundaryCondition(Zipper(), sign)
 
@@ -96,6 +97,9 @@ end
         end
     end
 
+    # We substitute the redundant part of the last row to ensure consistency
+    @inbounds c[i, Ny, k] = ifelse(i > Nx ÷ 2, c[i′, Ny, k], c[i, Ny, k])
+
     return nothing
 end
 
@@ -126,6 +130,9 @@ end
         end
     end
 
+    # We substitute the redundant part of the last row to ensure consistency
+    @inbounds c[i, Ny, k] = ifelse(i > Nx ÷ 2, c[i′, Ny, k], c[i, Ny, k])
+
     return nothing
 end
 

test/test_zipper_boundary_conditions.jl

@@ -43,4 +43,13 @@ using OrthogonalSphericalShellGrids: Zipper
     north_boundary_u_right = view(u.data, Nx+1, Ny+1:Ny+Hy, 1)
     @test all(north_boundary_u_left  .== 1)
     @test all(north_boundary_u_right .== 1)
-end
+
+    bottom(x, y) = rand()
+
+    grid = TripolarGrid(size = (10, 10, 1))
+    grid = ImmersedBoundaryGrid(grid, GridFittedBottom(bottom))
+
+    bottom_height = grid.immersed_boundary.bottom_height
+
+    @test interior(bottom_height, :, 10, 1) == interior(bottom_height, 10:-1:1, 10, 1)
+end