Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not import CUDA from ClimaCore and bump to 0.1.6 #50

Merged
merged 6 commits into from
May 2, 2024
Merged

Conversation

Sbozzolo
Copy link
Member

Closes #48

Ideally, one would probably want to consolidate the two calls and do not call CUDA directly.

Let's merge this after ClimaComms splits CUDA off too.

@Sbozzolo Sbozzolo force-pushed the gb/bump branch 3 times, most recently from 30fed33 to 7f74009 Compare April 26, 2024 16:28
@Sbozzolo Sbozzolo force-pushed the gb/bump branch 7 times, most recently from 8f344f1 to 38a16d6 Compare April 30, 2024 01:08
@Sbozzolo Sbozzolo requested a review from juliasloan25 April 30, 2024 15:06
@Sbozzolo Sbozzolo force-pushed the gb/bump branch 5 times, most recently from 048663a to 7b242a4 Compare April 30, 2024 23:12
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gabriele! I left some suggestions, mostly to add more comments. I also think it's a good idea to wait for the ClimaCore v0.14 release (today, hopefully), so we can include that in our compat

Project.toml Outdated Show resolved Hide resolved
ext/TimeVaryingInputs0DExt.jl Show resolved Hide resolved
src/OutputPathGenerator.jl Outdated Show resolved Hide resolved
src/OutputPathGenerator.jl Outdated Show resolved Hide resolved
NEWS.md Show resolved Hide resolved
@Sbozzolo Sbozzolo merged commit b814270 into main May 2, 2024
13 checks passed
@juliasloan25 juliasloan25 deleted the gb/bump branch May 2, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix imports
2 participants