Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback fixes #222

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Callback fixes #222

merged 2 commits into from
Oct 4, 2023

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 4, 2023

I think the ClimaAtmos branch is getting close to covering all of the edge cases, so I think it's a good time to start incorporating the post-callback fixes into ClimaTimeSteppers. The edge cases that we missed included:

  • Accounting for when !isnothing(T_imp!) && !iszero(a_imp[i, i]) is false
  • Krylov evaluations of f! (T_imp!) with something other than U/x-- which requires an additional post_implicit! call
  • Calling post_explicit!(U, p, t_imp) instead of post_explicit!(U, p, t_exp), and doing this after temp is computed (to preserve the existing behavior).
  • Finally, computing T_imp using the U from before the post_implicit! call, which requires injecting this into the callback (we add two closures to avoid unnecessary additional assignments).

Latest build, with (I think) all of these fixes is here:

https://buildkite.com/clima/climaatmos-ci/builds/13544

@charleskawczynski charleskawczynski merged commit efec3c3 into main Oct 4, 2023
@bors bors bot deleted the ck/fix branch October 4, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant