Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the ClimaAtmos branch is getting close to covering all of the edge cases, so I think it's a good time to start incorporating the post-callback fixes into ClimaTimeSteppers. The edge cases that we missed included:
!isnothing(T_imp!) && !iszero(a_imp[i, i])
is falsef!
(T_imp!
) with something other thanU
/x
-- which requires an additionalpost_implicit!
callpost_explicit!(U, p, t_imp)
instead ofpost_explicit!(U, p, t_exp)
, and doing this aftertemp
is computed (to preserve the existing behavior).T_imp
using theU
from before thepost_implicit!
call, which requires injecting this into the callback (we add two closures to avoid unnecessary additional assignments).Latest build, with (I think) all of these fixes is here:
https://buildkite.com/clima/climaatmos-ci/builds/13544