-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implementation of a modified EVP rheology #42
Draft
simone-silvestri
wants to merge
161
commits into
main
Choose a base branch
from
ss/evp-rheology
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l into ss/momentum-equation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tentative proposal for an implementation of a modified EVP rheology and an infrastructure to solve the momentum equations of sea ice.
This PR builds on top of #24, so a lot of changes here are duplicated. All names and implementations here can be changed.
The salient points of this implementation are:
An explicit momentum solver
encoded in the
ExplicitMomentumSolver
type, which containsdiffusivity_fields
in an oceananigans model)This type extends the
$$u^{n+1} = u^n + \frac{\Delta t}{\text{substeps}} \left[ \frac{C^D \rho_o}{m_i} \lVert \boldsymbol{U}_o - \boldsymbol{U}^n \rVert (u_o - u^{n+1}) + \tau_a + f \cdot v^n + g \frac{\partial \eta}{\partial x} + \frac{\partial \sigma}{\partial x_j}\right] + \frac{G^R_x}{\text{substeps}} $$
$$v^{n+1} = v^n + \frac{\Delta t}{\text{substeps}} \left[ \frac{C^D \rho_o}{m_i} \lVert \boldsymbol{U}_o - \boldsymbol{U}^n \rVert (u_o - v^{n+1}) + \tau_a - f \cdot u^{n+1} + g \frac{\partial \eta}{\partial y} + \frac{\partial \sigma}{\partial x_j}\right] + \frac{G^R_y}{\text{substeps}} $$ $v^{n+1}$ and use it to calculate $u^{n+1}$ . $G^R$ is a "rheology specific" tendency term
solve_momentum!
function where the momentum time stepping is a substepping performed with a forward-backward scheme where velocities in the Coriolis force are taken at them+1
substep. The ocean-sea ice stress is computed semi-implicitly.The equations solved are (on even substeps)
On odd substeps the order reverses so we solve first for
The substepping requires
compute_stresses!
kernel∂ⱼ_σ₁ⱼ
and∂ⱼ_σ₂ⱼ
pointwise functionsrheology_substep
pointwise function (if these are different than the substeps specified in theExplicitMomentumSolver
as in the modified EVP formulation)rheology_specific_forcing_x
andrheology_specific_forcing_y
functions for particular tendencies a particular rheology would like to add (While the initialization requires:
initialize_rheology!
functionrequired_auxiliary_fields
function that is called with a grid as an argument and allocates any necessary auxiliary fieldAll these functions must be extended by a possible new rheology to be compatible with the
ExplicitMomentumSolver
A modified EVP rheology
encoded in the
ExplicitViscoPlasticRheology
type.It extends the
compute_stresses!
function in accordance with the formulation of the rheology.The
rheology_specific_forcing_*
pointwise functions are the restoring to the previous velocities, for exampleThe auxiliary fields required for this rheology are:
while the stress divergence is simply
Validation scripts
There are two validation scripts that show the interface of the dynamics:
ice_advected_by_anticyclone.jl
andice_advected_on_triangular_coastline.jl
. The implementation for the moment is probably not 100% correct, because the output of the first one, that is supposed to reproduce the results in Simulating Linear Kinematic Features in Viscous-Plastic Sea Ice Models yields strange results:sea_ice_evp.mp4
Anyways, I am curious to know what people think about this implementation and open to changes, comments or even closing the PR if we decide to go in another direction