Change "thermal" to "heat" (in most places)

[glwagner]

After a bit of rumination I think we should use the term "heat flux" not "thermal flux". It's more standard. Sorry for any pain this causes...

@jlk9

[jlk9]

You need to change the directory and file names from "Thermal" to "Heat" too, in "ThermalBoundaryConditions" at least

[glwagner]

You need to change the directory and file names from "Thermal" to "Heat" too, in "ThermalBoundaryConditions" at least

thank you!

[codecov]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (05086bb) 22.80% compared to head (de6d239) 22.80%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   22.80%   22.80%           
=======================================
  Files          11       11           
  Lines         307      307           
=======================================
  Hits           70       70           
  Misses        237      237           

Files	Coverage Δ
src/ClimaSeaIce.jl	6.66% <ø> (ø)
...c/HeatBoundaryConditions/HeatBoundaryConditions.jl	50.00% <100.00%> (ø)
src/HeatBoundaryConditions/boundary_fluxes.jl	0.00% <ø> (ø)
...ndaryConditions/bottom_heat_boundary_conditions.jl	0.00% <0.00%> (ø)
...BoundaryConditions/top_heat_boundary_conditions.jl	0.00% <0.00%> (ø)
...rc/SlabSeaIceModels/slab_heat_and_tracer_fluxes.jl	0.00% <0.00%> (ø)
...SlabSeaIceModels/slab_tendency_kernel_functions.jl	0.00% <0.00%> (ø)
src/SlabSeaIceModels/slab_time_stepping.jl	0.00% <0.00%> (ø)
src/SlabSeaIceModels/slab_sea_ice_model.jl	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jlk9]

Did you want to change the name of IceWaterThermalEquilibrium as well?

[glwagner]

Did you want to change the name of IceWaterThermalEquilibrium as well?

I thought "thermal equilibrium" made sense to keep since that's the typical expression. For fluxes though we usually say "heat flux" not "thermal flux", that motivates the changes we've put in so far. What do you think?

[glwagner]

For example

https://en.wikipedia.org/wiki/Thermal_equilibrium

but

https://en.wikipedia.org/wiki/Heat_equation

[jlk9]

I agree, that's how I've usually heard fluxes / equilibrium referred to as well, just wanted to make sure.

[glwagner]

great!