-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MODIS LAI driver & use in experiments #973
base: main
Are you sure you want to change the base?
Conversation
A note - we dont run the benchmarks by default (or the long runs). You need to add the label to the PR, and then make a push to the branch to trigger them. it's a little annoying but better than running them every time |
I'm really not sure what's happening with the buildkite here - no changes to the manifest or anything so I don't know why there are so many failures in the packages/includes/imports? |
I had trouble today too, and cleared the depot. I tried rebuilding here - let's see if it runs now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good from the code point of view! I would also think we can use modis wherever we use ERA5 now. I just want to check that the number of NaNs in the simulation did not increase (would check when you rebase it and restart the long runs) and that the SYPD did not change much
@juliasloan25 a note for the OKR to run climaland for 20 years, we only have one year of MODIS data. But we can start with ERA5 data to assess stability as we are doing.
Purpose
This PR adds driver utilities to run simulations using MODIS LAI from 2008 as opposed to era5 LAI. Corresponding PR adding MODIS LAI data to ClimaArtifacts is here.
To-do
Content