delete cgll2latlonz function
#958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/string-name
branch
from
5b5e6f4 to
a165f8b
Compare
Sbozzolo
reviewed
Sep 20, 2024
juliasloan25
force-pushed
the
js/string-name
branch
from
a165f8b to
a6bb739
Compare
We have a function `Regridder.cgll2latlonz` that is a wrapper around wrappers around ClimaCoreTempestRemap functions. We have no use for it in source, and it is only called in a single test. This commit deletes the function, and calls the CCTR wrappers directly from the test where `cgll2latlonz` was called before.
juliasloan25
force-pushed
the
js/string-name
branch
from
a6bb739 to
7c91931
Compare
Sbozzolo
approved these changes
Sep 20, 2024
juliasloan25
changed the title
cgll2latlonz into testcgll2latlonz function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We have a function
Regridder.cgll2latlonzthat is a wrapper around wrappers around ClimaCoreTempestRemap functions. We have no use for it in source, and it is only called in a single test. This commit deletes the function, and calls the CCTR wrappers directly from the test wherecgll2latlonzwas called before.closes #833
Content