Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClimaUtilities Inputs in run_amip #937

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

Sbozzolo
Copy link
Member

ClimaUtilities comes with a rich array of tools to read input data. Among these are the SpaceVaryingInput and the TimeVaryingInput to read data from NetCDF files (and more). These functions are more efficient, versatile, and come with various interpolation options.

This commit moves AMIP to using those. In the process, it moves from using ClimaCoreTempestRemap to Interpolations.

Closes #916

@Sbozzolo Sbozzolo force-pushed the gb/timevaryinginputs branch 4 times, most recently from 15f5f41 to 6a8a4d5 Compare August 22, 2024 20:51
@Sbozzolo Sbozzolo marked this pull request as ready for review August 22, 2024 20:57
@Sbozzolo Sbozzolo force-pushed the gb/timevaryinginputs branch 2 times, most recently from 553007a to bab0371 Compare August 22, 2024 21:39
ClimaUtilities comes with a rich array of tools to read input data.
Among these are the `SpaceVaryingInput` and the `TimeVaryingInput` to
read data from NetCDF files (and more). These functions are more
efficient, versatile, and come with various interpolation options.

This commit moves AMIP to using those. In the process, it moves from
using ClimaCoreTempestRemap to Interpolations.
@Sbozzolo Sbozzolo force-pushed the gb/timevaryinginputs branch from bab0371 to 8897481 Compare August 22, 2024 21:56
@Sbozzolo Sbozzolo requested a review from szy21 August 22, 2024 22:16
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not entirely sure what interpolation_daily is doing (I assume it means getting updated once every day), and why land fraction is needed for some of the previous interpolation. But the code change looks good to me.

@Sbozzolo
Copy link
Member Author

Yes, interpolate daily updates the data once a day, otherwise data is read once a month.

@Sbozzolo Sbozzolo merged commit f874af7 into main Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to add a constant to prescribed SST
2 participants