Fix discard spinup in leaderboad and add best/worst single models #857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routine that was discarding the spinup period had a flipped sign which resulted in everything but the spinup being discard. Now that's fixed and the first 6 months are discarded. In fixing this, I added the model that minimize/maximise errors across all the metrics (normalized to the median RMSE).
I also started decoupling the code to produce the leaderboard from the driver so that it can be run independently. Now, it still lives in
run_amip.jl
but if ones changes these two lineswith the correct folders, the code will produce the leaderboard for the data that is found.
This is what the leaderboard looks now (540 days run, 180 discarded)