-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "triangle" plot #831
Add "triangle" plot #831
Conversation
665b4ea
to
cfd2dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Maybe we can get rid of the best model to make the plot less busy? Would it be hard to do the actual triangle plot (we don't need to do it now)?
My understanding of the spirit of the triangle plot is to visually compare
various models, so I thought that having the best model was important.
As for the triangles, what I can easily do is make them squares. That is,
condense all the squares I have now as sub-squares of one square (instead
of sub triangles of one square).
Making triangles would add more more code.
…On Mon, Jun 3, 2024, 6:55 AM Zhaoyi Shen ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good to me, thanks! Maybe we can get rid of the best model to make
the plot less busy? Would it be hard to do the actual triangle plot (we
don't need to do it now)?
—
Reply to this email directly, view it on GitHub
<#831 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACF6E7OTZCNUDEJNNC2FOC3ZFRYW5AVCNFSM6AAAAABITTV4S6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJTHE2TENZXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sounds good, let's keep the best model. And let's move to sub-squares once we have more variables (unless it's very easy to do). |
4050f08
to
963f1bc
Compare
Fixes compatibility with ClimaCore
Let's make it square. :)
In this PR, I add a plot that compares our model with the best model (where best is the one that minimizes RMSEs). Errors are reported in terms of median RMSE