Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass in job_id as command line argument #804

Merged
merged 2 commits into from
May 23, 2024
Merged

pass in job_id as command line argument #804

merged 2 commits into from
May 23, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented May 20, 2024 •
edited
Loading

Purpose

closes #776

Content

  • pass in job_id to runs via command line
  • remove job_id from config files
  • delete GPU-specific config files
  • remove run_name option, which was a duplicate of job_id
  • replace all uses of run_name with job_id (this is more consistent with Atmos's convention)
  • set animations to false if running on GPU (this was manually being specified in config files before)
  • confirm no behavioral changes from main
  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/jobid branch 4 times, most recently from 6fd47af to 988cd39 Compare May 20, 2024 19:50
@juliasloan25 juliasloan25 requested review from LenkaNovak and anastasia-popova and removed request for LenkaNovak May 20, 2024 19:53
anastasia-popova
anastasia-popova approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@anastasia-popova anastasia-popova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@juliasloan25 juliasloan25 force-pushed the js/jobid branch 2 times, most recently from 2abe255 to e21dad6 Compare May 23, 2024 16:58
@juliasloan25 juliasloan25 enabled auto-merge May 23, 2024 18:31
@juliasloan25 juliasloan25 merged commit 7d4027f into main May 23, 2024
7 checks passed
@juliasloan25 juliasloan25 deleted the js/jobid branch May 23, 2024 18:58
@juliasloan25 juliasloan25 mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasia-popova anastasia-popova anastasia-popova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove job_id from config files
2 participants
@juliasloan25 @anastasia-popova