Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add moist Held-Suarez run script #801

Merged
merged 1 commit into from
May 23, 2024
Merged

Add moist Held-Suarez run script #801

merged 1 commit into from
May 23, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented May 20, 2024 •
edited
Loading

closes #760

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak force-pushed the ln/moist-hs branch 5 times, most recently from a5cbdbb to eccb719 Compare May 22, 2024 21:47
@LenkaNovak LenkaNovak marked this pull request as ready for review May 22, 2024 22:03
@LenkaNovak LenkaNovak requested a review from juliasloan25 May 22, 2024 22:03
juliasloan25
juliasloan25 reviewed May 22, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Lenka! I had some questions throughout

.buildkite/hierarchies/pipeline.yml Show resolved Hide resolved
.buildkite/pipeline.yml Outdated Show resolved Hide resolved
docs/src/fluxcalculator.md Show resolved Hide resolved
experiments/ClimaEarth/run_dry_held_suarez.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_moist_held_suarez.jl Show resolved Hide resolved
@LenkaNovak LenkaNovak requested a review from juliasloan25 May 22, 2024 22:56
juliasloan25
juliasloan25 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think it might be nice to rename the _modified to _short, but other than that I think this is good to go

@LenkaNovak
Copy link
Collaborator Author

Awesome, thank you for the review! 🚀

@LenkaNovak
init
b7cb707 
pip

post rebase

post rebase

tj params

atmos init mod

clean

runs

runs

nomenclature for most

format

format

clean

format

config passing

clean

config passing

clean

fix

rev

rev
@LenkaNovak LenkaNovak enabled auto-merge May 22, 2024 23:50
@LenkaNovak LenkaNovak merged commit da361b4 into main May 23, 2024
7 checks passed
LenkaNovak added a commit that referenced this pull request May 23, 2024
@LenkaNovak
Merge pull request #801 from CliMA/ln/moist-hs
a5367b4 
Add moist Held-Suarez run script

init

clean

clean params

clean params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hierarchies: Moist Held-Suarez driver
2 participants
@LenkaNovak @juliasloan25