-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readme to amip #689
Add readme to amip #689
Conversation
@LenkaNovak @Julians42 I addressed the comments for the previous PR, added some more description to edmf, and moved it to experiments/AMIP/README. For some reason the old PR was not updated so I opened a new one. Would you like to look at it again? |
87abedb
to
12f37a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @szy21! Just a couple of comments.
experiments/AMIP/README.md
Outdated
|
||
Radiation: A scheme based on RRTM for General circulation model applications—Parallel (RRTMGP) (Pincus et al. 2019) | ||
|
||
Convection and turbulence: Diagnostic Eddy-diffusivity Mass-Flux (EDMF) scheme with prognostic turbulent kinetic energy. EDMF is a unified parameterization for turbulence and convection. The grid is decomposed into convective updrafts and the turbulent enrionment. Updraft properties are calculated from mass, momentum and energy conservation of the updraft. Mass and momentum exchange between the updrafts and the environment, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enrionment -> environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I think it's ready to merge after you address Lenka's comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @szy21
Purpose
Closes #652
To-do
Content