Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme to amip #689

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add readme to amip #689

merged 1 commit into from
Mar 15, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Mar 13, 2024

Purpose

Closes #652

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member Author

szy21 commented Mar 13, 2024

@LenkaNovak @Julians42 I addressed the comments for the previous PR, added some more description to edmf, and moved it to experiments/AMIP/README. For some reason the old PR was not updated so I opened a new one. Would you like to look at it again?

@szy21 szy21 force-pushed the zs/amip_docs branch 2 times, most recently from 87abedb to 12f37a9 Compare March 13, 2024 01:52
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @szy21! Just a couple of comments.

experiments/AMIP/README.md Outdated Show resolved Hide resolved

Radiation: A scheme based on RRTM for General circulation model applications—Parallel (RRTMGP) (Pincus et al. 2019)

Convection and turbulence: Diagnostic Eddy-diffusivity Mass-Flux (EDMF) scheme with prognostic turbulent kinetic energy. EDMF is a unified parameterization for turbulence and convection. The grid is decomposed into convective updrafts and the turbulent enrionment. Updraft properties are calculated from mass, momentum and energy conservation of the updraft. Mass and momentum exchange between the updrafts and the environment, and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enrionment -> environment

experiments/AMIP/README.md Show resolved Hide resolved
experiments/AMIP/README.md Outdated Show resolved Hide resolved
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I think it's ready to merge after you address Lenka's comments

@szy21 szy21 requested a review from LenkaNovak March 14, 2024 17:19
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @szy21

@szy21 szy21 enabled auto-merge March 15, 2024 00:25
@szy21 szy21 merged commit 5dc1ea6 into main Mar 15, 2024
7 checks passed
@juliasloan25 juliasloan25 deleted the zs/amip_docs branch March 15, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add checklist of AMIP requirements to docs
3 participants