update sea_breeze plots #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
juliasloan25
force-pushed
the
js/seabreeze-plots
branch
2 times, most recently
from
6501983 to
6151962
Compare
juliasloan25
force-pushed
the
js/seabreeze-plots
branch
3 times, most recently
from
d74a0cb to
3bfeb95
Compare
juliasloan25
force-pushed
the
js/seabreeze-plots
branch
2 times, most recently
from
8cdb247 to
64b689a
Compare
juliasloan25
force-pushed
the
js/seabreeze-plots
branch
3 times, most recently
from
d4005ee to
7b4fcb7
Compare
LenkaNovak
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Thank you, looks great, @juliasloan25 ! Just a couple of comments.
juliasloan25
force-pushed
the
js/seabreeze-plots
branch
from
7b4fcb7 to
d9ec194
Compare
juliasloan25
force-pushed
the
js/seabreeze-plots
branch
from
d9ec194 to
95aa73d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add updated seabreeze animations showing convection to buildkite. This was first implemented in #540 but that has additional changes we don't want in main.
Closes #533
Status 5 Jan 2024
Results are nondeterministic, probably because of random initial condition in atmosphere. I tried initializing the atmosphere with 0 everywhere instead, but that didn't produce any reasonable results.
Status 3 March 2024
After setting the random seed, the results are reproducible and look good :)