Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test Float32 compatibility #534

Merged
merged 5 commits into from
Dec 14, 2023
Merged

test Float32 compatibility #534

merged 5 commits into from
Dec 14, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Dec 2, 2023 •
edited
Loading

Purpose

closes #449

To Do

  • make ClimaLSM Float32 compatible
  • extend tests to check Float32 and Float64
    • all component models, and unit tests for which it makes sense (FT is used or computation is done)
  • add Float32 runs (AMIP and slabplanet) to buildkite

@juliasloan25 juliasloan25 self-assigned this Dec 2, 2023
@juliasloan25 juliasloan25 force-pushed the js/ft32 branch 2 times, most recently from 76109b9 to afc5614 Compare December 2, 2023 02:17
@juliasloan25 juliasloan25 force-pushed the js/ft32 branch 7 times, most recently from 8517932 to ccc5166 Compare December 6, 2023 23:44
LenkaNovak
LenkaNovak approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor comments. Thank you!

.buildkite/pipeline.yml Outdated Show resolved Hide resolved
src/FieldExchanger.jl Show resolved Hide resolved
test/diagnostics_tests.jl Show resolved Hide resolved
test/flux_calculator_tests copy 2.jl Outdated Show resolved Hide resolved
test/flux_calculator_tests copy.jl Outdated Show resolved Hide resolved
test/interfacer_tests.jl Outdated Show resolved Hide resolved
@juliasloan25 juliasloan25 force-pushed the js/ft32 branch 5 times, most recently from b25cb61 to 0d783df Compare December 11, 2023 02:52
@juliasloan25 juliasloan25 force-pushed the js/ft32 branch 3 times, most recently from 203754a to 036378c Compare December 11, 2023 19:58
LenkaNovak
LenkaNovak approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revs LGTM. There was one more non-local FT call, I think, otherwise feel free to merge. Thank you!

@juliasloan25
Copy link
Member Author

Ah yes, I think I had missed one in interfacer_tests.jl. It should be updated now!

@juliasloan25 juliasloan25 merged commit 8571a76 into main Dec 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees

@juliasloan25 juliasloan25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable Float32 compatibility
2 participants
@juliasloan25 @LenkaNovak