move CoupledSim to Interfacer

[juliasloan25]

Purpose

closes #333

Components:

• move the code
• revamp unit tests

QA

• ensure there is no behavioral change in Buildkites (AMIP paperplots (namely the 32 day run), conservation check for slabplanet, performance in build_history)

Questions:

• src/CoupledSimulations/coupled_simulation.jl CoupledSimulation vs Interfacer.CoupledSimulation - why is this type defined in two places?
• timestepping.md refers to ClimaCoupler.CoupledSimulation - which of the two types is this?
• should we keep AbstractSimulation defined in Interfacer? This is also defined in src/CoupledSimulations/coupled_simulation.jl as well

---

• I have read and checked the items on the review checklist.

[juliasloan25]

@LenkaNovak could you help me understand the questions I have in the PR description?

• src/CoupledSimulations/coupled_simulation.jl CoupledSimulation vs Interfacer.CoupledSimulation - why is this type defined in two places?
• timestepping.md refers to ClimaCoupler.CoupledSimulation - which of the two types is this?
• should we keep AbstractSimulation defined in Interfacer? This is also defined in src/CoupledSimulations/coupled_simulation.jl as well

[LenkaNovak]

Sure:

• 1. src/CoupledSimulations/ files were placeholders for the Simulations-like interface. Since we're not going to implement this in the near future, we can probably remove it (as long as it doesn't clash with the sea_breeze example. If it does, then we can revamp this as part of a different PR that updates the ClimaCore examples). Same goes for src/CouplerState/
• 2. timestepping.md refers to this outdated code and should be removed. There will be more similar files to clean up for the release, so we should go over these on Monday.
• 3. similar to point 1. The AbstactSimulaiton in src/CoupledSimulations/ is outdated, but it may break the sea breeze case if we remove it without modifying the example's run script.

[juliasloan25]

I think getting rid of the src/CoupledSimulations and src/CoupledState folders will change enough code that I want to do it in a separate PR: #458

[juliasloan25]

bors r+

[bors]

Canceled.

[juliasloan25]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• buildkite/climacoupler-ci
• ci 1.9 - macOS-latest
• ci 1.9 - ubuntu-latest
• ci 1.9 - windows-latest
• docbuild
• format