Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AMIP debug plots #452

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add AMIP debug plots #452

merged 1 commit into from
Oct 4, 2023

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Oct 2, 2023 •
edited
Loading

Purpose

closes #328

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak mentioned this pull request Oct 2, 2023
Closed
1 task
@LenkaNovak LenkaNovak marked this pull request as ready for review October 2, 2023 23:53
juliasloan25
juliasloan25 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Do we want to output these plots from any buildkite jobs, or just manually generate these when debugging?

@LenkaNovak
Copy link
Collaborator Author

Thanks for the review! I can tag a unit test that doesn't require an interactive run.

@LenkaNovak
init plots
24f60ba 
clean

clean

add unit test

add printf
@LenkaNovak
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 0e4e570 into main Oct 4, 2023
8 checks passed
@bors bors bot deleted the ln/debug_plots branch October 4, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add debug plots
2 participants
@LenkaNovak @juliasloan25