Add flamegraphs #236
Merged
Add flamegraphs #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenkaNovak
force-pushed
the
ln/flamegraphs
branch
3 times, most recently
from
e2173ea to
9cb0541
Compare
juliasloan25
approved these changes
Jan 28, 2023
.buildkite/pipeline.yml
Outdated
| artifact_paths: "experiments/AMIP/moist_mpi_earth/output/amip/target_amip_n32_shortrun_artifacts/*" | ||
| env: | ||
| CLIMACORE_DISTRIBUTED: "MPI" | ||
| agents: | ||
| slurm_ntasks: 32 | ||
| slurm_mem_per_cpu: 16G | ||
|
|
||
| # performance tests | ||
| - label: ":rocket: performance: flame graph and allocation tests" |
There was a problem hiding this comment.
it might be helpful each of the performance tests has a unique label and artifact_paths so we can tell them apart more easily and avoid overwriting outputs
| @@ -320,7 +324,7 @@ cs = CoupledSimulation{FT}( | |||
| coupler_fields, | |||
| parsed_args, | |||
| conservation_checks, | |||
| tspan, | |||
| [tspan[1], tspan[2]], | |||
There was a problem hiding this comment.
would it be simpler to initialize tspan as an array of length 2 instead? i.e. tspan = [Int(0), t_end], then we can just pass in tspan here.
There was a problem hiding this comment.
Doing it this way allows specifying tspan as a Tuple (like in Atmos's global arguments which overwrites our tspan) or as an array. I know... and I agree that we should unify this, once we don't have synonymous global variables lingering about in the background. :)
transfer + modify from ClimaCore/ClimaAtmos add alloc benchmarks add buildkite driver rev allocs docs activate docs clean fix doc fix doc fix check in perf Manifest bkite flag order fix scope fix FT redef error fix fix stash fix clean rebase fixes rebase fix bkite rev1
LenkaNovak
force-pushed
the
ln/flamegraphs
branch
from
06f719b to
3346bf9
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses the first component of #229
To-do