Avoid abstract types in structs #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriabarra
force-pushed
the
valeria/opt-structs
branch
from
5cae9ca to
a467da5
Compare
|
@LenkaNovak this passes CI and it's ready for review. Thanks! |
valeriabarra
force-pushed
the
valeria/opt-structs
branch
from
a467da5 to
107ece5
Compare
LenkaNovak
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Thanks, @valeriabarra ! Looks good. I wonder if DiagnosticsGroup and DataPackage could benefit from similar optimisations? After that feel free to merge.
Co-authored-by: Charles Kawczynski <[email protected]>
valeriabarra
force-pushed
the
valeria/opt-structs
branch
from
afc5cde to
9d24918
Compare
|
bors r+ |
valeriabarra
changed the title
1 task
bors bot
added a commit
that referenced
this pull request
Feb 7, 2023
251: BCReader: type safety and avoid abstarct type in struct r=valeriabarra a=valeriabarra ## Purpose This PR is a follow-up of #227 . It improves type safety and compiler optimization by removing abstract types in the BCReader struct. Closes #250 ## Content It improves type safety and compiler optimization by removing abstract types in the BCReader struct. Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. - [x] I have read and checked the items on the review checklist. Co-authored-by: Valeria Barra <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 7, 2023
251: BCReader: type safety and avoid abstarct type in struct r=valeriabarra a=valeriabarra ## Purpose This PR is a follow-up of #227 . It improves type safety and compiler optimization by removing abstract types in the BCReader struct. Closes #250 ## Content It improves type safety and compiler optimization by removing abstract types in the BCReader struct. Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. - [x] I have read and checked the items on the review checklist. Co-authored-by: Valeria Barra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Charles Kawczynski [email protected]
Purpose
This PR concretizes a few types in composite types for better compiler optimizations.
Closes #224
Content
with:
float_type_csasfloat_typeand added docstringFT <: RealinBCFileInfostructReview checklist
I have:
In the Content, I have included
relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.
I have read and checked the items on the review checklist.