Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bucket initial condition #1129

Merged
merged 1 commit into from
Dec 19, 2024
Merged

add bucket initial condition #1129

merged 1 commit into from
Dec 19, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Dec 16, 2024 •
edited
Loading

Purpose

Adds an option to read bucket initial condition from a netcdf file

To-do

Content

  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/bucket_initcond branch 4 times, most recently from 4af75ee to 8e8ce86 Compare December 18, 2024 17:56
@szy21 szy21 marked this pull request as ready for review December 18, 2024 17:57
@szy21 szy21 force-pushed the zs/bucket_initcond branch 3 times, most recently from 931cdc4 to 17e0f6c Compare December 18, 2024 18:08
@szy21 szy21 force-pushed the zs/bucket_initcond branch from 17e0f6c to ae01661 Compare December 18, 2024 19:38
juliasloan25
juliasloan25 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

experiments/ClimaEarth/components/land/climaland_bucket.jl Show resolved Hide resolved
@szy21 szy21 force-pushed the zs/bucket_initcond branch 3 times, most recently from 96b0394 to 5cdc50b Compare December 19, 2024 00:00
@szy21 szy21 force-pushed the zs/bucket_initcond branch from 5cdc50b to c8a2012 Compare December 19, 2024 00:01
@szy21 szy21 merged commit 73dcb28 into main Dec 19, 2024
11 checks passed
@szy21 szy21 deleted the zs/bucket_initcond branch December 19, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szy21 @Sbozzolo @juliasloan25