Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load OrderedDict #1114

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Load OrderedDict #1114

merged 1 commit into from
Dec 10, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Dec 9, 2024

PR #1103 and #1094 are inconsistent. This uses OrderedDict directly from ClimaAnalysis

PR #1103 and #1094 are inconsistent. This uses OrderedDict directly from
ClimaAnalysis
Copy link
Contributor

@imreddyTeja imreddyTeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just make OrderedCollections an explicit and direct dependency?

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Dec 9, 2024

Should we just make OrderedCollections an explicit and direct dependency?

I don't think it's really strongly needed at this point. If it becomes more important, we can turn it into a direct dependency

@Sbozzolo Sbozzolo enabled auto-merge December 9, 2024 21:42
@Sbozzolo Sbozzolo merged commit 9e5bf06 into main Dec 10, 2024
9 checks passed
@Sbozzolo Sbozzolo deleted the gb/fix branch December 10, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants