Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change artifact path for heat-diffusion on buildkite #1096

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Nov 21, 2024

Purpose

Save the output plots of the heat-diffusion experiment on buildkite.
closes #1095

To-do

Content

  • changed artifact path to match output path
  • Now build kite heat-diffusion shows 3 saved artifacts vs 0 before

  • I have read and checked the items on the review checklist.

@juliasloan25
Copy link
Member

juliasloan25 commented Nov 22, 2024

Good catch! I missed the heat diffusion example when I changed the artifact paths in e4bbc30. I changed the paths so the artifacts are in a subdirectory of the directory created for the job, rather than another directory at the same level (e.g. amip_default_artifacts/ became amip_default/artifacts/. To keep the heat diffusion example consistent with everything else, we should update the dir used in the example (here), rather than in the pipeline.

Previously the artifacts dir did not match with the buildkite
pipeline.
@imreddyTeja imreddyTeja force-pushed the tr/fix-buildkite-heat_diffusion-artifacts branch from deb7cd3 to 36255f8 Compare November 22, 2024 19:49
@imreddyTeja imreddyTeja merged commit d9156a6 into main Nov 24, 2024
11 checks passed
@imreddyTeja imreddyTeja deleted the tr/fix-buildkite-heat_diffusion-artifacts branch November 24, 2024 04:01
Sbozzolo pushed a commit that referenced this pull request Dec 11, 2024
Previously the artifacts dir did not match with the buildkite
pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifacts from the heat_diffusion experiment not saved on buildkite
2 participants