Fix differentiability of local element map #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 23, 2022
909: Fix differentiability of local element map r=simonbyrne a=simonbyrne I was experimenting with `IntrinsicMap` and noticed some sign errors in the metric terms due to the non-differentiable extra branches for handling of signed zeros. This is a simpler and better approach. - [X] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [X] Unit tests are included OR N/A. - [X] Code is exercised in an integration test OR N/A. - [X] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 24, 2022
853: add special cases for projection from Covariant => Contravariant r=charleskawczynski a=simonbyrne 909: Fix differentiability of local element map r=simonbyrne a=simonbyrne I was experimenting with `IntrinsicMap` and noticed some sign errors in the metric terms due to the non-differentiable extra branches for handling of signed zeros. This is a simpler and better approach. - [X] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [X] Unit tests are included OR N/A. - [X] Code is exercised in an integration test OR N/A. - [X] Documentation has been added/updated OR N/A. 910: Fix Zalesak FCT docstring and add it to the Docs r=simonbyrne a=valeriabarra This PR adds the Zalesak FCT operator to the docs since #887 did not include it. Plus some additional doc fixes and improvements. - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]> Co-authored-by: Valeria Barra <[email protected]>
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2022
853: add special cases for projection from Covariant => Contravariant r=charleskawczynski a=simonbyrne 909: Fix differentiability of local element map r=simonbyrne a=simonbyrne I was experimenting with `IntrinsicMap` and noticed some sign errors in the metric terms due to the non-differentiable extra branches for handling of signed zeros. This is a simpler and better approach. - [X] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [X] Unit tests are included OR N/A. - [X] Code is exercised in an integration test OR N/A. - [X] Documentation has been added/updated OR N/A. 914: Fix test failures on Julia 1.8 r=simonbyrne a=simonbyrne Builds on #912 - [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code is exercised in an integration test OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2022
909: Fix differentiability of local element map r=simonbyrne a=simonbyrne I was experimenting with `IntrinsicMap` and noticed some sign errors in the metric terms due to the non-differentiable extra branches for handling of signed zeros. This is a simpler and better approach. - [X] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [X] Unit tests are included OR N/A. - [X] Code is exercised in an integration test OR N/A. - [X] Documentation has been added/updated OR N/A. 914: Fix test failures on Julia 1.8 r=simonbyrne a=simonbyrne Builds on #912 - [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code is exercised in an integration test OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with
IntrinsicMapand noticed some sign errors in the metric terms due to the non-differentiable extra branches for handling of signed zeros. This is a simpler and better approach.