Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a special case for ClimaTimeSteppers, where
the environment decsribed by test/Project.toml was used. This caused
errors because the test/Project.toml file was removed. So, the temporary test
environment generated wth Pkg.test() must be used. This does not work,
because it requires dev-ing ClimaCore from the ClimaTimeSteppers project,
which causes an Aqua test to fail.
ClimaUtilities was not passing because dev-ing ClimaCore
caused aqua tests to fail. A possible solution to this is
making a special case, similar to what was done for ClimaTimeSteppers.
I attempted to dev ClimaCore in the temporary test env generated
by Pkg.Test() by passing in
-e using Pkg; Pkg.dev(...)
as a juliaarg to Pkg.test, but that did not work.
Julia 1.11 adds a kwarg to Pkg.add, which specifies the field
inside the Project.toml file that a package should be added to.
If we only used 1.11, we could add the path to ClimaCore and specify
the target as extra or weakdeps, which would allow aqua tests to pass.
Instead, this commit makes the downstream test install TestEnv
into the base julia env, then activate the test env for the downstream
package, then devs ClimaCore, and then run the test suite.
The ClimaTimeSteppers downstream tests still fail. This is an issue with ClimaTimeSteppers because the same test errors when run through the ClimaTimeSteppers CI. See issue and example here