Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tr/fix ci downstream tests #2105

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Tr/fix ci downstream tests #2105

merged 1 commit into from
Dec 17, 2024

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Dec 17, 2024

Previously, there was a special case for ClimaTimeSteppers, where
the environment decsribed by test/Project.toml was used. This caused
errors because the test/Project.toml file was removed. So, the temporary test
environment generated wth Pkg.test() must be used. This does not work,
because it requires dev-ing ClimaCore from the ClimaTimeSteppers project,
which causes an Aqua test to fail.

ClimaUtilities was not passing because dev-ing ClimaCore
caused aqua tests to fail. A possible solution to this is
making a special case, similar to what was done for ClimaTimeSteppers.

I attempted to dev ClimaCore in the temporary test env generated
by Pkg.Test() by passing in -e using Pkg; Pkg.dev(...) as a julia
arg to Pkg.test, but that did not work.

Julia 1.11 adds a kwarg to Pkg.add, which specifies the field
inside the Project.toml file that a package should be added to.
If we only used 1.11, we could add the path to ClimaCore and specify
the target as extra or weakdeps, which would allow aqua tests to pass.

Instead, this commit makes the downstream test install TestEnv
into the base julia env, then activate the test env for the downstream
package, then devs ClimaCore, and then run the test suite.

The ClimaTimeSteppers downstream tests still fail. This is an issue with ClimaTimeSteppers because the same test errors when run through the ClimaTimeSteppers CI. See issue and example here

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@imreddyTeja imreddyTeja force-pushed the tr/fix-ci-downgrade-tests branch 3 times, most recently from 6f741bc to 40ec2f4 Compare December 17, 2024 17:33
@imreddyTeja imreddyTeja changed the title Tr/fix ci downgrade tests Tr/fix ci downstream tests Dec 17, 2024
@imreddyTeja imreddyTeja force-pushed the tr/fix-ci-downgrade-tests branch 3 times, most recently from 3c76f0c to 16a7f37 Compare December 17, 2024 18:08
Previously, there was a special case for ClimaTimeSteppers, where
the environment decsribed by test/Project.toml was used. This caused
errors because the Project.toml file was removed. So, the temporary test
environment generated wth Pkg.test() must be used. This does not work,
because it requires dev-ing ClimaCore from the ClimaTimeSteppers project,
which causes an Aqua test to fail.

ClimaUtilities was not passing because dev-ing ClimaCore
caused aqua tests to fail. A possible solution to this is
making a special case, similar to what was done for ClimaTimeSteppers.

I attempted to dev ClimaCore in the temporary test env generated
by Pkg.Test() by passing in `-e using Pkg; Pkg.dev(...)` as a julia
arg to Pkg.test, but that did not work.

Julia 1.11 adds a kwarg to Pkg.add, which specifies the field
inside the Project.toml file that a package should be added to.
If we only used 1.11, we could add the path to ClimaCore and specify
the target as extra or weakdeps, which would allow aqua tests to pass.

Instead, this commit makes the downstream test install TestEnv
into the base julia env, then activate the test env for the downstream
package, then dev ClimaCore, and then run the test suite.
@imreddyTeja imreddyTeja force-pushed the tr/fix-ci-downgrade-tests branch from 16a7f37 to 3756754 Compare December 17, 2024 19:28
@imreddyTeja imreddyTeja marked this pull request as ready for review December 17, 2024 20:28
@imreddyTeja imreddyTeja requested a review from Sbozzolo December 17, 2024 20:28
@Sbozzolo Sbozzolo merged commit 6ad8294 into main Dec 17, 2024
33 of 35 checks passed
@Sbozzolo Sbozzolo deleted the tr/fix-ci-downgrade-tests branch December 17, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants