Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify IntervalSets and OrderedCollections #2081

Closed
wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

This PR qualifies types/methods in IntervalSets and OrderedCollections.

This is a peel off of #2078.

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for OrderedCollections is more subtle. I moved it to a different commit here: c35c57c

I have to remove OrderedCollecions because I could not find a lower version that was compatible.

@charleskawczynski
Copy link
Member Author

The change for OrderedCollections is more subtle. I moved it to a different commit here: c35c57c

I have to remove OrderedCollecions because I could not find a lower version that was compatible.

Hm, that's a bit odd, DataStructures just depends on OrderedCollections

@Sbozzolo
Copy link
Member

I tried a little bit and couldn't get it to work. Given that the package is only use in tests and we already depend on DataStructures, it was simpler and quicker to just use DataStructures directly.

@charleskawczynski
Copy link
Member Author

I tried a little bit and couldn't get it to work. Given that the package is only use in tests and we already depend on DataStructures, it was simpler and quicker to just use DataStructures directly.

That's a bit unfortunate, I'd prefer we use the lower level dependencies. That said, having correctly configured lower compat bounds seems like a much bigger win to me. So I'm fine with this.

Superseded by #2078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants