Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded domain field into unstructured 2D mesh struct. #205

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Embedded domain field into unstructured 2D mesh struct. #205

merged 3 commits into from
Sep 23, 2021

Conversation

sriharshakandala
Copy link
Member

No description provided.

@sriharshakandala sriharshakandala force-pushed the sk/embed_domain_into_mesh branch from 6a66fd5 to e503e72 Compare September 22, 2021 18:47
@jakebolewski
Copy link
Contributor

@sriharshakandala I think this needs to be rebased after #201 is merged. Looking at it though I don't think it will be too bad, also #201 allows for the coordinate types defined in #81 to be applied for the sphere.

jakebolewski
jakebolewski reviewed Sep 22, 2021
View reviewed changes
src/Meshes/Meshes.jl Outdated Show resolved Hide resolved
src/Domains/Domains.jl Outdated Show resolved Hide resolved
@sriharshakandala sriharshakandala force-pushed the sk/embed_domain_into_mesh branch 2 times, most recently from d02e7dc to a4b58aa Compare September 22, 2021 22:17
@sriharshakandala sriharshakandala force-pushed the sk/embed_domain_into_mesh branch 3 times, most recently from 590f798 to e97628a Compare September 23, 2021 00:47
@sriharshakandala sriharshakandala force-pushed the sk/embed_domain_into_mesh branch from e97628a to 8c22aa0 Compare September 23, 2021 00:52
@sriharshakandala
Copy link
Member Author

@jakebolewski : I rebased the code with master. I also added the bickley jet CG experiment with unstructured mesh to the buildkite so that changes relevant to unstructured mesh will also be carried over wherever newer PRs are added.

@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 23, 2021
@bors
Try #205:
a8744f9
@jakebolewski
Copy link
Contributor

Nice, seems to be a bit simpiler and is more in line with what we do for the vertical warping. LGTM

@bors
Copy link
Contributor

bors bot commented Sep 23, 2021

try

Build succeeded:

@jakebolewski jakebolewski self-requested a review September 23, 2021 13:20
@sriharshakandala
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 23, 2021

Build succeeded:

@bors bors bot merged commit 3d02f72 into main Sep 23, 2021
@bors bors bot deleted the sk/embed_domain_into_mesh branch September 23, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebolewski jakebolewski jakebolewski approved these changes

@simonbyrne simonbyrne Awaiting requested review from simonbyrne

Assignees
No one assigned
Labels
Unstructured 2D mesh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sriharshakandala @jakebolewski