Add DataLayouts convenience constructors #2033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found myself churning a lot of code in the test suite, related to construction of datalayouts.
This PR adds new convenience constructors for datalayouts, meant to be used at the top-level (as they are not inferable).
They have a few advantages over the existing way we construct them. Concretely, they:
Nf
So, instead of writing
We can write:
So, this will hopefully reduce the surface area of these constructors if we use them consistently in the test suite.