Add information about deep grid in restart files #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
requested review from
charleskawczynski,
sriharshakandala and
dennisYatunin
Sbozzolo
force-pushed
the
gb/fix_bubble
branch
from
836f665 to
7da49ec
Compare
Sbozzolo
force-pushed
the
gb/fix_bubble
branch
3 times, most recently
from
8303554 to
900aca6
Compare
Sbozzolo
force-pushed
the
gb/fix_bubble
branch
from
900aca6 to
f7964d7
Compare
charleskawczynski
approved these changes
Oct 2, 2024
Sbozzolo
force-pushed
the
gb/fix_bubble
branch
from
f7964d7 to
bd8a1b8
Compare
Before this commit, == for FieldVectors with different types was falling back to the AbstractArray ==, resulting in false positives. Now FieldVectors with different types are always considered different.
This commit adds some information that was lost in saving to a checkpoint: the `deep` option. It also adds tests for types too, making the tests more stringent
Sbozzolo
force-pushed
the
gb/fix_bubble
branch
from
bd8a1b8 to
c97cc03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some information that was lost in saving to a checkpoint: the
deepoption. It also adds tests for types too, making the tests more stringent.This also fixes an issue with
rcomparefor different types of FieldVectors.Closes #2022