Fix Julia 1.11 #2018
Merged
Fix Julia 1.11 #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/julia1p11
branch
from
d3a1ed6 to
5be3111
Compare
|
Let's merge this, I think seeing upstream issues early will be useful, despite that I think this shouldn't be needed. At least support for multi-dimensional indexing is localized to this small section (before #1920, our dependency on it was much more widespread). |
charleskawczynski
force-pushed
the
ck/julia1p11
branch
from
643ff53 to
84c5eb7
Compare
|
Note to self: we could even evaluate these additional methods only if we're on julia 1.11 or greater, so that we don't accidentally depend on the multi-dimensional indexing anywhere else in julia 1.10. I may follow up on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively reverts part of #1920, and should (hopefully) fix CI on Julia 1.11. This should close #1923.
I don't think that this should actually be needed, but it seems that there have been changes to Julia Base's broadcasting that require multi-dimensional indexing.