Remove unnecessary method specializations for Numbers #2014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appear to be inference issues arising from unnecessary specializations on
Number
types in severalRecursiveApply
methods. Specifically, the specializations forrdiv
(but not forrmul
) are the source of the first bug described in #1983, and removing them fixes that error. Removing these specializations may also fix other inference problems for operations on complex fields (e.g., matrix fields of non-scalar values).Several specializations of
rmuladd
are not removed in this PR becausermap
does not currently support 3 input arguments (only 1 or 2). This can be fixed in the future, especially if we end up rewritingrmap
in terms ofunrolled_map
.