Fix inference for column broadcasting #1984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that what was missing here is that
column
on broadcasted objects passesnothing
to the axes. So, even though we callinstantiate
on the broadcasted objects in the Fields broadcasting:We later call
column
inside the datalayouts loop:Which then drops the axes and passes in
nothing
. This results in looking up theaxes
insidegetindex
rather thancolumn
.I'm kind of surprised that this wasn't a more wide spread issue. Also, it oddly didn't seem to have a performance benefit, but at least it fixes inference and conceptually makes more sense this way.
Closes #1981.