Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for CubedSphere to 0.3 #1972

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Bump compat for CubedSphere to 0.3 #1972

merged 2 commits into from
Sep 9, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Sep 6, 2024

CubedSphere 0.3 does not introduce any new feature, it moves some accessory features out of the package. In this, most dependencies are dropped.

Now, ClimaCore no longer depends on FFTW and the various other dependencies that are pulled in with FFTW.

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I remembered there was a related issue with FFTW, but it turns out that this was in ClimateMachine (CliMA/ClimateMachine.jl#1478). So, that's a nice dependency to remove.

@charleskawczynski
Copy link
Member

charleskawczynski commented Sep 6, 2024

Hm, the error is a bit odd. It kind of looks like OrdinaryDiffEq was able to upgrade, but changes didn't appear in the manifest. I'll try pushing a commit to update the manifests.

@charleskawczynski
Copy link
Member

It looks like OrdinaryDiffEq broke into many subpackages? Maybe we can now adjust our dependencies on it in the test/examples environment.

@charleskawczynski
Copy link
Member

Weird, the versions got downgraded During develop or instantiate. I’m gonna try clearing the depot.

@charleskawczynski
Copy link
Member

Looks like we'll need to update this, limit OrdinaryDiffEq, or figure out how to eliminate this dependency. @dennisYatunin, was update_W! part of the public API?

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Sep 6, 2024

Many of the places where OrdindaryDiffEq is currently used should be changed with SciMLBase.

@charleskawczynski
Copy link
Member

Many of the places where OrdindaryDiffEq is currently used should be changed with SciMLBase.

Yeah, I tried removing it a while back, but we need some of the algorithms, which don't exist in SciMLBase. Maybe we can use the subpackages now that it's split

@charleskawczynski
Copy link
Member

charleskawczynski commented Sep 9, 2024

Alright, @Sbozzolo, want to try rebasing? I think that this should now work.

CubedSphere 0.3 does not introduce any new feature, it moves some accessory
features out of the package. In this, most dependencies are dropped.
@charleskawczynski charleskawczynski merged commit 3fd62e1 into main Sep 9, 2024
21 of 22 checks passed
@charleskawczynski charleskawczynski deleted the gb/cubedsphere branch September 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants