-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compat for CubedSphere to 0.3 #1972
Conversation
490e947
to
8fb708a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I remembered there was a related issue with FFTW, but it turns out that this was in ClimateMachine (CliMA/ClimateMachine.jl#1478). So, that's a nice dependency to remove.
Hm, the error is a bit odd. It kind of looks like OrdinaryDiffEq was able to upgrade, but changes didn't appear in the manifest. I'll try pushing a commit to update the manifests. |
It looks like OrdinaryDiffEq broke into many subpackages? Maybe we can now adjust our dependencies on it in the test/examples environment. |
Weird, the versions got downgraded During develop or instantiate. I’m gonna try clearing the depot. |
86a699d
to
6b7a8f1
Compare
Looks like we'll need to update this, limit OrdinaryDiffEq, or figure out how to eliminate this dependency. @dennisYatunin, was |
Many of the places where OrdindaryDiffEq is currently used should be changed with SciMLBase. |
Yeah, I tried removing it a while back, but we need some of the algorithms, which don't exist in SciMLBase. Maybe we can use the subpackages now that it's split |
Alright, @Sbozzolo, want to try rebasing? I think that this should now work. |
CubedSphere 0.3 does not introduce any new feature, it moves some accessory features out of the package. In this, most dependencies are dropped.
6b7a8f1
to
831dbf9
Compare
CubedSphere 0.3 does not introduce any new feature, it moves some accessory features out of the package. In this, most dependencies are dropped.
Now, ClimaCore no longer depends on FFTW and the various other dependencies that are pulled in with FFTW.