Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and refactors the benchmarks in a few ways:
CUDA.name(CUDA.device())
to look up the device specsNow, we can add more devices in
device_specs
.kernel_time_s
topush_info
so that it's decoupled fromnreps
. This is clearer and becomes compatible with benchmarks generated from BenchmarkToolsproblem_size
intopush_info
, so that a benchmark table can have multiple problem sizes (this is helpful for our copyto benchmarks)copyto!
benchmarks.