add hyperbolic tangent stretching #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/stretching
branch
5 times, most recently
from
316f6f7 to
a0d4694
Compare
tapios
reviewed
Aug 13, 2024
szy21
force-pushed
the
zs/stretching
branch
2 times, most recently
from
68aebf8 to
6d8237c
Compare
szy21
force-pushed
the
zs/stretching
branch
2 times, most recently
from
79a0a50 to
c542ba5
Compare
|
To clarify, we are not hard coding linear terrain-following coordinates here. The code can be cleaned up though, I agree. We will refactor it in separate PRs. |
szy21
force-pushed
the
zs/stretching
branch
3 times, most recently
from
6608872 to
0abee99
Compare
szy21
commented
Aug 15, 2024
| @@ -305,7 +310,7 @@ function IntervalMesh( | |||
| h = | |||
| h_bottom .+ | |||
| (ζ_n .- ζ_n[1]) * (h_top - h_bottom) / (ζ_n[end - 1] - ζ_n[1]) | |||
| faces = (z_bottom + (z_top - z_bottom)) * exp_stretch.(ζ_n, h) | |||
| faces = z_bottom .+ (z_top - z_bottom) * exp_stretch.(ζ_n, h) | |||
There was a problem hiding this comment.
@charleskawczynski Here is a bug fix. Would this be a breaking change? This technically changes the behavior of the vertical mesh, but since we always use z_bottom = 0 in ClimaAtmos, it wouldn't change the results. Just want to make sure if the next climacore release should be a minor or patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1927. Also fixes a bug in stretching for non-zero z_bottom.