Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matrix fields on spectral and point spaces #1884

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jul 12, 2024

Relaxes type restrictions and adds new methods so we can create MatrixFields for spectral spaces and point spaces
TODO: add helpful error message for printing formatted Jacobian

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@kmdeck
Copy link
Member Author

kmdeck commented Jul 12, 2024

@dennisYatunin I will add some unit tests, but this seems to be working

@kmdeck kmdeck force-pushed the kd/matrix_fields branch from c02841d to b492dc4 Compare July 26, 2024 18:42
@kmdeck kmdeck requested a review from dennisYatunin July 26, 2024 19:08
Copy link
Member

@dennisYatunin dennisYatunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It'll be helpful to add a simple unit test that reflects your use case. And have you checked whether this works on GPUs? It's possible that we'll need to do some additional tinkering in ClimaCoreCUDAExt for this.

src/MatrixFields/MatrixFields.jl Outdated Show resolved Hide resolved
src/MatrixFields/matrix_shape.jl Outdated Show resolved Hide resolved
@kmdeck kmdeck force-pushed the kd/matrix_fields branch 2 times, most recently from 4a6a290 to c5aeb16 Compare August 5, 2024 18:52
@kmdeck kmdeck self-assigned this Aug 5, 2024
@kmdeck kmdeck requested a review from dennisYatunin August 5, 2024 18:55
@kmdeck
Copy link
Member Author

kmdeck commented Aug 5, 2024

@dennisYatunin ready for a re-review! this branch was used on GPU in a clima land run, so I think it is OK on that front. additionally, if CC unit tests run on GPU, this PR also tests the addition via test/MatrixFields/flat_spaces.jl.

test/MatrixFields/flat_spaces.jl Outdated Show resolved Hide resolved
test/MatrixFields/flat_spaces.jl Outdated Show resolved Hide resolved
test/MatrixFields/flat_spaces.jl Outdated Show resolved Hide resolved
@kmdeck kmdeck force-pushed the kd/matrix_fields branch from e57e8be to cbbee35 Compare August 5, 2024 21:58
@kmdeck kmdeck enabled auto-merge August 5, 2024 21:58
@kmdeck kmdeck merged commit feb7247 into main Aug 5, 2024
16 of 19 checks passed
@kmdeck kmdeck deleted the kd/matrix_fields branch August 5, 2024 23:12
@kmdeck kmdeck mentioned this pull request Sep 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants