Add inference test and improve inference of _SpectralElementGrid2D
#1818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes inference failures from 351 -> 189 in
_SpectralElementGrid2D
.The main problem here, I think, was that the compiler was boxing
CoordType2D
, so this PR moves that logic to a separate function (sometimes the compiler struggles with understanding types if a variable is computed in multiple places, even in the context of union-splitting).