Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and improve inference of monotonic_check #1810

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

charleskawczynski
Copy link
Member

This PR adds unit tests for monotonic_check, and inference tests (a step towards #1797). Previously, the closure z was getting captured inside any, and map was returning an object.

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charleskawczynski charleskawczynski force-pushed the ck/monotonic_check branch 3 times, most recently from 9202cdf to 659b0c8 Compare June 14, 2024 19:43
@charleskawczynski
Copy link
Member Author

charleskawczynski commented Jun 14, 2024

Unfortunately, I'm getting slightly different inference results locally compared to central for the cuda inference. I'll try to match the central numbers I'm going to pick the conservative numbers so that my local machine passes CI, too. Hopefully we can eventually drive this down to 0 on both. I'll rely on @test_opt for decision making on the CPU, since I think that is a better metric, anyway.

@charleskawczynski charleskawczynski merged commit cc3e571 into main Jun 14, 2024
8 of 9 checks passed
@charleskawczynski charleskawczynski deleted the ck/monotonic_check branch June 14, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants