Add wrapper for FieldMatrix and FieldMatrixSolver #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/field_matrix_wrapper
branch
from
3227620 to
bf04421
Compare
Sbozzolo
approved these changes
Jun 7, 2024
|
Looks good, please fix the tests, and maybe let's make another release so that we can use it in ClimaTimeSteppers. |
dennisYatunin
force-pushed
the
dy/field_matrix_wrapper
branch
2 times, most recently
from
7804a14 to
ecd27ad
Compare
Sbozzolo
force-pushed
the
dy/field_matrix_wrapper
branch
from
ecd27ad to
b4dc488
Compare
charleskawczynski
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Overall I think that this is an improvement, but I think that some names can be improved. Let's let #1787 get through and rebase this, first.
Sbozzolo
force-pushed
the
dy/field_matrix_wrapper
branch
from
b4dc488 to
c10bf48
Compare
Sbozzolo
force-pushed
the
dy/field_matrix_wrapper
branch
2 times, most recently
from
233eca1 to
1172357
Compare
Sbozzolo
force-pushed
the
dy/field_matrix_wrapper
branch
from
1172357 to
d4ae6ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
InvertibleFieldMatrixstruct, which is a simple wrapper for aFieldMatrixand a correspondingFieldMatrixSolver. The wrapper has a constructor that specifies a defaultFieldMatrixSolverAlgorithm, and it also has methods forsimilar,ldiv!, andmul!. This should allow us to remove a lot of boilerplate code that is currently needed to set up implicit solvers (see this comment in ClimaTimeSteppers).