Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field_matrix_solve! reproducer #1750

Merged
merged 2 commits into from
May 22, 2024
Merged

add field_matrix_solve! reproducer #1750

merged 2 commits into from
May 22, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented May 22, 2024

Adds a unit test implementing a reproducer for #1749. I'm not sure where the best place to add this test is, so I'm happy to move it to a different file if preferred!

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@charleskawczynski
Copy link
Member

Alright, I pushed the fix, and it seems to fix the unit test. I've also updated the news and bumped the patch version. I'll merge once this passes CI and make a patch release after merging.

@charleskawczynski
Copy link
Member

Closes #1749.

@charleskawczynski charleskawczynski merged commit 63ad94f into main May 22, 2024
12 of 15 checks passed
@charleskawczynski charleskawczynski deleted the js/reproducer branch May 22, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants