3 component dss transform #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysridhar
force-pushed
the
as/test-dss
branch
6 times, most recently
from
792234d to
083495f
Compare
akshaysridhar
force-pushed
the
as/test-dss
branch
8 times, most recently
from
392c1ef to
8fd0a5d
Compare
|
cc @sriharshakandala there's an issue when running a GPU example (e.g. sphere baroclinic wave rhoe) with the updates here when tracking this branch in ClimaAtmos; the CPU cases run without issues. |
akshaysridhar
force-pushed
the
as/test-dss
branch
2 times, most recently
from
a46feb7 to
6f7ab8a
Compare
akshaysridhar
force-pushed
the
as/test-dss
branch
9 times, most recently
from
c6a6716 to
4365301
Compare
akshaysridhar
force-pushed
the
as/test-dss
branch
7 times, most recently
from
0b09015 to
fc14c3e
Compare
akshaysridhar
force-pushed
the
as/test-dss
branch
from
74b64f7 to
aec1fbf
Compare
akshaysridhar
force-pushed
the
as/test-dss
branch
13 times, most recently
from
c38d9f8 to
1c571c0
Compare
|
@dennisYatunin There are some soft-fails in |
Those are compilation-intensive unit tests that have been soft-failing for a while. The buildkite run looks good to me. |
3rd velocity component instead of treating it
as a scalar variable
modified: ext/cuda/topologies_dss.jl
modified: src/Topologies/dss.jl
modified: src/Topologies/dss_transform.jl
modified: test/Spaces/terrain_warp.jl
modified: test/Spaces/ddss1_cs.jl
+format
Remove dss-op on surface elevation horizontal gradient
modified: src/Hypsography/Hypsography.jl
akshaysridhar
force-pushed
the
as/test-dss
branch
from
1c571c0 to
c3e5322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dss_transform function treats the 3rd component of a
Covariant123Vector datatype as a scalar. This PR updates the metric index getter methods and the transform functions to apply the 3 component vector dss.