fixes for land implicit solver #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/land-fixes
branch
2 times, most recently
from
65ff1c4 to
1b52952
Compare
7 tasks
juliasloan25
force-pushed
the
js/land-fixes
branch
from
1b52952 to
a8ec493
Compare
juliasloan25
force-pushed
the
js/land-fixes
branch
from
7c0bd7d to
3a9c695
Compare
charleskawczynski
approved these changes
Apr 23, 2024
juliasloan25
force-pushed
the
js/land-fixes
branch
7 times, most recently
from
75b50fd to
23da572
Compare
juliasloan25
force-pushed
the
js/land-fixes
branch
from
23da572 to
81e6aff
Compare
juliasloan25
force-pushed
the
js/land-fixes
branch
3 times, most recently
from
e557b21 to
9f533e1
Compare
juliasloan25
force-pushed
the
js/land-fixes
branch
from
9f533e1 to
cfe166a
Compare
|
https://buildkite.com/clima/climacore-ci/builds/3525 already passed, so I'll just go ahead and manually merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes are needed for GPU compatibility of the land implicit solver using the updated interface: CliMA/ClimaLand.jl#542
passing build in ClimaAtmos using this branch: https://buildkite.com/clima/climaatmos-ci/builds/18472#_
Content
adapt_structurefor all operator and boundary condition typesunrolled_mapinmultiply_matrix_at_indexto avoid the recursive inference limit when compiling nested matrix operations