Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use .style for FieldVectorStyle #1658

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Dont use .style for FieldVectorStyle #1658

merged 2 commits into from
Apr 4, 2024

Conversation

charleskawczynski
Copy link
Member

I think this should fix the failure in #1657.

@Sbozzolo
Copy link
Member

Sbozzolo commented Apr 3, 2024

Do you know why this is failing only in 1.9?

@charleskawczynski
Copy link
Member Author

Do you know why this is failing only in 1.9?

style must be an internal field, that was added in 1.10. There was always an associated style type, but perhaps not a field.

Sbozzolo
Sbozzolo approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sbozzolo
Copy link
Member

Sbozzolo commented Apr 4, 2024

You can also add an entry in the NEWS if you feel like

@charleskawczynski charleskawczynski merged commit 30b823c into main Apr 4, 2024
11 of 12 checks passed
@charleskawczynski charleskawczynski deleted the ck/broadcast_fv branch April 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @Sbozzolo