Always inline #1647
Merged
Always inline #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/cuda_inline
branch
from
a5abd53 to
57469f6
Compare
|
I'd be good to check that this doesn't break coupler and land too. |
|
Agreed, there’s still one thing to fix in atmos |
|
Atmos is fixed. |
charleskawczynski
force-pushed
the
ck/cuda_inline
branch
from
57469f6 to
9500663
Compare
|
I'm going to merge this, and we can fix the issues we run into. |
charleskawczynski
force-pushed
the
ck/cuda_inline
branch
from
9500663 to
54fdc2c
Compare
I am rebuilding your PR in Land that tests this out. |
This was referenced Apr 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all cuda kernel launches always inline, since this can reduce function call overhead. In addition, it could allow the compiler to hoist memory reads/writes.