Fix interpolate! for MPI runs #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For MPI runs, dest does not to be an array. Quite the opposite: all the processes except root will not have an array as destination, but they will still call `interpolate!`
Sbozzolo
requested review from
charleskawczynski,
dennisYatunin and
sriharshakandala
Comment on lines
+783
to
+785
| if !isnothing(dest) | ||
| # !isnothing(dest) means that this is the root process, in this case, the size have | ||
| # to match |
There was a problem hiding this comment.
What happens below if this is not the root process?
There was a problem hiding this comment.
Each MPI process has to run the code below. Each MPI process performs interpolation of its local points, then there is a MPI reduce! call to move everything to root and save it to dest.
charleskawczynski
approved these changes
Mar 11, 2024
|
ClimaCore 0.13.1 running in Atmos with interpoalte!: https://buildkite.com/clima/climaatmos-ci/builds/17355 Everything passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interpolate!did not allowdestto benothing, as we would have in MPI runs (we only allocatedeston root).This fix is blocking me from using it in ClimaAtmos, so I am also making a patch release.