Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define Adapt for PointSpace #1554

Merged
merged 1 commit into from
Nov 18, 2023
Merged

define Adapt for PointSpace #1554

merged 1 commit into from
Nov 18, 2023

Conversation

simonbyrne
Copy link
Member

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

simonbyrne
simonbyrne commented Nov 17, 2023
View reviewed changes
src/Spaces/pointspace.jl Outdated Show resolved Hide resolved
@simonbyrne simonbyrne requested a review from Sbozzolo November 17, 2023 21:59
@Sbozzolo Sbozzolo force-pushed the sb/point-space-adapt branch 7 times, most recently from 528ea18 to 55a28b4 Compare November 18, 2023 00:32
@Sbozzolo Sbozzolo force-pushed the sb/point-space-adapt branch from 55a28b4 to 6719dfa Compare November 18, 2023 00:37
@Sbozzolo Sbozzolo marked this pull request as ready for review November 18, 2023 14:30
@Sbozzolo Sbozzolo merged commit ee9badd into main Nov 18, 2023
14 checks passed
@Sbozzolo Sbozzolo deleted the sb/point-space-adapt branch November 18, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbyrne @Sbozzolo