Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up hybrid plane examples directory. #1542

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Clean up hybrid plane examples directory. #1542

merged 1 commit into from
Nov 13, 2023

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Nov 13, 2023

Removes 4 experiments and their corresponding buildkite entries.

  • density_current_2dinvariant_rhotheta.jl
  • bubble_2d_invariant_rhotheta.jl
  • topo_dc_2dinvariant_rhoe.jl
  • bubble_2d_rhotheta.jl

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of migrating examples to unit tests. My only concern is whether this exercises code that is otherwise not exercised. I ran into several such cases when making changes to metric terms (where unit tests missed broken parts that examples caught).

@simonbyrne
Copy link
Member

I'm generally in favor of migrating examples to unit tests. My only concern is whether this exercises code that is otherwise not exercised. I ran into several such cases when making changes to metric terms (where unit tests missed broken parts that examples caught).

Can you link to them? My experience has been that the examples directory usually passes since the example don't have any @tests in them.

@akshaysridhar
Copy link
Member Author

akshaysridhar commented Nov 13, 2023

cc @charleskawczynski https://buildkite.com/clima/climacore-ci/builds/2819#018bca05-66f7-45e0-8ba4-0b57763fc014 Here is perhaps one example of a failure in the perf env; is there a specific reason to use this rho_theta example to generate the perf flamegraph ?

@akshaysridhar akshaysridhar force-pushed the as/rm-ex branch 2 times, most recently from ce9ed6d to db46e4c Compare November 13, 2023 21:24
	deleted:    bubble_2d_invariant_rhotheta.jl
	deleted:    bubble_2d_rhotheta.jl
	deleted:    density_current_2dinvariant_rhotheta.jl
	deleted:    topo_dc_2dinvariant_rhoe.jl
	modified:   perf/flame.jl
@charleskawczynski
Copy link
Member

Can you link to them?

I don't have any on hand, I'd have to go digging, and not all buildkite builds in the past are still available.

My experience has been that the examples directory usually passes since the example don't have any @tests in them.

Yes, but any example that simply exercises code will still, e.g., throw method errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants