Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify GitHub Actions #1538

Merged
merged 2 commits into from
Nov 9, 2023
Merged

simplify GitHub Actions #1538

merged 2 commits into from
Nov 9, 2023

Conversation

simonbyrne
Copy link
Member

Will need to update branch protections to merge this

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne simonbyrne force-pushed the sb/github-actions-test branch from f1a1942 to dc36c43 Compare November 8, 2023 21:04
@simonbyrne simonbyrne requested a review from Sbozzolo November 8, 2023 21:23
@Sbozzolo
Copy link
Member

Sbozzolo commented Nov 8, 2023

Is the test on Julia 1.10 required to pass?

@simonbyrne
Copy link
Member Author

Currently this won't pass: for this to merge we will have to change the required checks.

@simonbyrne
Copy link
Member Author

But to actually answer your question: we can just specify which ones we want to pass (so I can make it just the 1.9 ones for now)

@Sbozzolo Sbozzolo self-requested a review November 8, 2023 22:26
@simonbyrne
Copy link
Member Author

I've changed the required checks, so this one needs to get merged before any others

@simonbyrne simonbyrne enabled auto-merge (rebase) November 9, 2023 17:26
@simonbyrne simonbyrne disabled auto-merge November 9, 2023 17:26
@simonbyrne simonbyrne enabled auto-merge (squash) November 9, 2023 17:27
@simonbyrne simonbyrne merged commit 546e102 into main Nov 9, 2023
13 checks passed
@simonbyrne simonbyrne deleted the sb/github-actions-test branch November 9, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants