Add broken GPU limiters tests, and GPU dispatch mechanism #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
requested review from
simonbyrne,
Sbozzolo and
sriharshakandala
charleskawczynski
force-pushed
the
ck/hlimiters_gpu_test
branch
from
9df757d to
6cb2ec6
Compare
Sbozzolo
reviewed
Oct 24, 2023
Sbozzolo
approved these changes
Oct 24, 2023
|
Also, please squash the commits! :) (If any of them is failing) |
charleskawczynski
force-pushed
the
ck/hlimiters_gpu_test
branch
2 times, most recently
from
eb51c9f to
eddcec2
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 24, 2023
1517: Add broken GPU limiters tests, and GPU dispatch mechanism r=charleskawczynski a=charleskawczynski This PR: - Adds GPU limiter tests - Fixes the limiter test to `ClimaComms.device()` - Adds a GPU dispatch mechanism, so that GPU paths are separated from CPU paths, but they currently do nothing (will follow up with implementation in a separate PR). Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed:
|
Make limiters use ClimaComms device Add gpu dispatch path mechanism Test fixes Apply formatter
charleskawczynski
force-pushed
the
ck/hlimiters_gpu_test
branch
from
eddcec2 to
1963208
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ClimaComms.device()