Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlining and threading of regular broadcasting #1481

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Inlining and threading of regular broadcasting #1481

merged 5 commits into from
Oct 3, 2023

Conversation

simonbyrne
Copy link
Member

Last fix to #1455.

Gets us to over 4 SYPD on a single GPU (https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/85#018ae2cc-8cef-4c77-a9d9-dc444f05645d)

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne simonbyrne changed the title Sb/inline more Inlining and threading of regular broadcasting Sep 29, 2023
@sriharshakandala
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Sep 30, 2023
@bors
Copy link
Contributor

bors bot commented Sep 30, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 1, 2023
1481: Inlining and threading of regular broadcasting r=simonbyrne a=simonbyrne

Last fix to #1455.

Gets us to over 4 SYPD on a single GPU (https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/85#018ae2cc-8cef-4c77-a9d9-dc444f05645d)

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 1, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 1, 2023
1481: Inlining and threading of regular broadcasting r=simonbyrne a=simonbyrne

Last fix to #1455.

Gets us to over 4 SYPD on a single GPU (https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/85#018ae2cc-8cef-4c77-a9d9-dc444f05645d)

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
1481: Inlining and threading of regular broadcasting r=simonbyrne a=simonbyrne

Last fix to #1455.

Gets us to over 4 SYPD on a single GPU (https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/85#018ae2cc-8cef-4c77-a9d9-dc444f05645d)

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build failed:

@charleskawczynski
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
1481: Inlining and threading of regular broadcasting r=charleskawczynski a=simonbyrne

Last fix to #1455.

Gets us to over 4 SYPD on a single GPU (https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/85#018ae2cc-8cef-4c77-a9d9-dc444f05645d)

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build failed:

@simonbyrne simonbyrne linked an issue Oct 2, 2023 that may be closed by this pull request
Co-authored-by: Sriharsha Kandala <[email protected]>
Co-authored-by: Sriharsha Kandala <[email protected]>
@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
1481: Inlining and threading of regular broadcasting r=simonbyrne a=simonbyrne

Last fix to #1455.

Gets us to over 4 SYPD on a single GPU (https://buildkite.com/clima/climaatmos-target-gpu-simulations/builds/85#018ae2cc-8cef-4c77-a9d9-dc444f05645d)

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <[email protected]>
@simonbyrne
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Canceled.

@simonbyrne
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a819730 into main Oct 3, 2023
@bors bors bot deleted the sb/inline-more branch October 3, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline all the things
3 participants